#1017 New testimonial pages

Merged
max.mehl merged 12 commits from lucas.lasota/fsfe-website:NEWTESTIMONIALPAGES into master 2 years ago
Collaborator

Hi Max,

I am uploading the new interview pages and the dynamic content for the testimonial's page. Please check the if everything is fine.

For that I created a new branch and followed the workflow.

Thank you

Lucas

Hi Max, I am uploading the new interview pages and the dynamic content for the testimonial's page. Please check the if everything is fine. For that I created a new branch and followed the workflow. Thank you Lucas
max.mehl requested changes 2 years ago
max.mehl left a comment

A few minor issues after skimming the files. Probably not all detected, but will give you a few pointer for further review

about/people/feeds/testimonials/3800-zerolo.en.xml Outdated
Watch our short interview with Tomás
</watch>
<read link="interviews/zerolo.html#interview">
Read our short interview with Tomás
max.mehl commented 2 years ago

Some syntax error here, also reported in Drone.

The closing </read> is missing

Some syntax error here, also reported in [Drone](https://drone.fsfe.org/FSFE/fsfe-website/2332/3). The closing `</read>` is missing
lucas.lasota commented 2 years ago

Fixed, thanks!

Fixed, thanks!
about/people/interviews/lequertier.en.xhtml Outdated
<p class="question"> Does it make a difference if Artificial Intelligence is based on Free Software? </p>
<p class="answer">Yes, absolutely! I will even go as far as saying that Artificial Intelligence based on non-free software is not usable. AI is not a solved problem. Far from it. You must use Free Software to inspect what the AI-based software does. Understanding how Artificial Intelligence is working is hard enough already, so we need to have all the source code and help available to grasp it. This is why all popular Deep Learning (a subpart of Artificial Intelligence) libraries are Free Software. For example
<a href="https://tensorflow.org/" target="_blanc">Tensorflow</a>
max.mehl commented 2 years ago

Please do not create new lines here. This causes the text to appear like this, so with an extra space after the link itself.

For example Tensorflow , Keras , Pytorch , etc.

Instead, make it like:

For example <a href="https://tensorflow.org/" target="_blanc">Tensorflow</a>, <a href="https://keras.io/" target="_blanc">Keras</a>, ...

Please do not create new lines here. This causes the text to appear like this, so with an extra space after the link itself. For example [Tensorflow](https://tensorflow.org/) , [Keras](https://keras.io/) , [Pytorch](https://keras.io/) , etc. Instead, make it like: `For example <a href="https://tensorflow.org/" target="_blanc">Tensorflow</a>, <a href="https://keras.io/" target="_blanc">Keras</a>, ...`
lucas.lasota commented 2 years ago

Checked and fixed on this and all other files.

Checked and fixed on this and all other files.
about/people/interviews/lequertier.en.xhtml Outdated
<p class="question">What is your favourite Free Software?</p>
<p class="answer">My favorite Free Software is
<a href="https://www.mozilla.org/en-US/firefox/" target="_blanc">Firefox</a>
max.mehl commented 2 years ago

Another line break with a link. Please fix it, and other occurences at other files

Another line break with a link. Please fix it, and other occurences at other files
lucas.lasota commented 2 years ago

Fixed on this and all other files

Fixed on this and all other files
about/people/interviews/mueller.en.xhtml Outdated
<blockquote>
<div class="with-image-right">
<img class="img-circle" src="/picturebase/people/2018-reinhard-mueller-300px" alt="Müller"/>
max.mehl commented 2 years ago

.jpg is missing from the filename

.jpg is missing from the filename
lucas.lasota commented 2 years ago

Added on this and all other files

Added on this and all other files
about/people/interviews/snow.en.xhtml Outdated
<blockquote>
<div class="with-image-right">
<img class="img-circle" src="/picturebase/people/2018-florian-snow-300px" alt="Snow"/>
max.mehl commented 2 years ago

file extension also missing here. Probably also in other places as well?

file extension also missing here. Probably also in other places as well?
lucas.lasota commented 2 years ago

Added on this and all other files

Added on this and all other files
about/people/interviews/weitzhofer.en.xhtml Outdated
future?</p>
<p class="answer">Since most of us worked with computers for a long time, I think we're still a little stuck in the mindset of equating "software" with "desktop computer application software".
<br/>
max.mehl commented 2 years ago

The use of <br /> in a paragraph is usually discouraged. Please remove it if not really necessary. Otherwise, create a new paragraph, so put it in a new <p> tag. Please also look for other occurences of <br /> or <br/> respectively.

The use of `<br />` in a paragraph is usually discouraged. Please remove it if not really necessary. Otherwise, create a new paragraph, so put it in a new `<p>` tag. Please also look for other occurences of `<br />` or `<br/>` respectively.
lucas.lasota commented 2 years ago

Fixed on this and all other files.

Fixed on this and all other files.
max.mehl changed title from NEWTESTIMONIALPAGES to New testimonial pages 2 years ago
max.mehl commented 2 years ago
Poster
Owner

Your new branch is still unclean, but let's fix that later.

Please make your edits to this branch, so NEWTESTIMONIALPAGES

Your new branch is still unclean, but let's fix that later. Please make your edits to this branch, so `NEWTESTIMONIALPAGES`
vincent requested changes 2 years ago
vincent left a comment

Also left comments. Thank you for working on this!

about/people/interviews/gkotsopoulou.en.xhtml Outdated
<h2 class="question">What is your favourite FSFE campaign at the moment?</h2>
<p class="answer"><a href="https://publiccode.eu" target="_blanc">"Public Money? Public Code!"</a> </p>
vincent commented 2 years ago

_blanc is not a valid attribute for target. Ref here. Can you please change all occurrences to _blank?

`_blanc` is not a valid attribute for `target`. Ref [here](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/target). Can you please change all occurrences to `_blank`?
lucas.lasota commented 2 years ago

Fixed in this and all other files.

Fixed in this and all other files.
about/people/interviews/lequertier.en.xhtml Outdated
All the others benefits of Free Software also make a difference for AI: the ability to share the source code stimulates innovation, ensures the software can be made secure and prevent it from being locked-down.
<br/>
You can read more about Free software and Deep Learning in my recent
<a href="https://skysymbol.noblogs.org/post/2018/09/10/on-deep-learning-and-free-software">blog post.</a> </p>
vincent commented 2 years ago

My blog moved from skysymbol.noblogs.org to vl8r.eu. Can you please change the link to 'https://vl8r.eu/post/2018/09/10/on-deep-learning-and-free-software/'?

My blog moved from [skysymbol.noblogs.org](https://skysymbol.noblogs.org) to [vl8r.eu](https://vl8r.eu). Can you please change the link to 'https://vl8r.eu/post/2018/09/10/on-deep-learning-and-free-software/'?
lucas.lasota commented 2 years ago

Changed ;)

Changed ;)
Poster
Collaborator

Thank you very much for the review!

All spotted issues were fixed. I checked the other files for similar issues and changed them accordingly.

Please verify if the codes are good to go. If so, please merge :)

Thank you very much for the review! All spotted issues were fixed. I checked the other files for similar issues and changed them accordingly. Please verify if the codes are good to go. If so, please merge :)
vincent approved these changes 2 years ago
vincent left a comment

Thanks for the fixes!

max.mehl approved these changes 2 years ago
max.mehl closed this pull request 2 years ago
max.mehl referenced this issue from a commit 2 years ago
The pull request has been merged as 23f5b65a9f.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.