Merchandise order form allows selection of wrong shipping option #877

New Issue

reinhard · 2019-04-15T08:54:28Z

reinhard commented

2019-04-15 08:54:28 +00:00

The merchandise order form does not verify whether the selected shipping option matches the country of the shipping address. So it's currently possible, for example, to enter Germany as the detination address and still select the option for internation shipping.

reinhard added the

cgi Scripting

label 2019-04-15 10:07:55 +00:00

monochromec self-assigned this 2019-05-25 13:36:10 +00:00

monochromec commented

2019-05-27 16:52:32 +00:00

When trying to push the changes, I get the following error message:

! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://git.fsfe.org/FSFE/fsfe-website

Apparently this boils down to some server-side scripts doing a form of pre-validation. As soon as this is fixed, I am going to try to push the changes again.

When trying to push the changes, I get the following error message: ! [remote rejected] master -> master (pre-receive hook declined) error: failed to push some refs to 'https://git.fsfe.org/FSFE/fsfe-website Apparently this boils down to some server-side scripts doing a form of pre-validation. As soon as this is fixed, I am going to try to push the changes again.

max.mehl commented

2019-05-27 17:13:56 +00:00

@monochromec, you seem to push to upstream master, this is discouraged. Could you please open a new branch on either your fork or this repo, and create a pull request?

vincent commented

2019-05-27 17:49:06 +00:00

Also, as the pre-validation is checking for valid xml files, there might be an issue with the syntax.

Also, [as the pre-validation is checking for valid xml files](https://git.fsfe.org/FSFE/fsfe-website/src/commit/c1fc1dbf9719d566c805a4ae5cba7e0fda030b99/tools/githooks/pre-receive), there might be an issue with the syntax.

monochromec commented

2019-05-28 04:37:32 +00:00

Hi @Max, I'm pretty sure I created a new branch when I cloned the repo but I'll double-check. @vincent: Would it be possible to post / send me the output of the bash script including the error message so that I can try to recreate the issue with the XML file failing (if it's an XML error)?

max.mehl commented

2019-05-28 09:30:17 +00:00

@monochromec These are the two hooks that we have running: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/githooks

I strongly suggest to activate the client-side pre-commit hook: https://wiki.fsfe.org/TechDocs/Mainpage/Editing#Enabling_XML_syntax_check

@monochromec These are the two hooks that we have running: https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/githooks I strongly suggest to activate the client-side pre-commit hook: https://wiki.fsfe.org/TechDocs/Mainpage/Editing#Enabling_XML_syntax_check

monochromec commented

2019-05-28 09:37:45 +00:00

Sorry, forgot to checkout the branch - I'm getting old :-). Commits have now been pushed but as I don't have the back-end locally, Q/A has been limited. Let me know if there are any issues with the code.

reinhard referenced this issue from a commit

2019-09-03 15:28:12 +00:00

Add automatic shipping costs determination Shipping costs are now automatically determined based on the country selected in the address. At the same time, the numbers were adapted to our real costs, and also we now only differ between within Germany and worldwide. Fixes #877

reinhard closed this issue

2019-09-03 15:28:12 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#877