"Last changed" in footer displays build info instead of commit info #837

New Issue

reinhard · 2019-03-15T08:37:26Z

reinhard commented

2019-03-15 08:37:26 +00:00

The "Last changed:" in the footer of each page displays the date of the last build run and the fixed text "automatic" instaed of the date of the last change to the source file and the author of that change.

reinhard added the

build

system-hackers

xsl

labels 2019-03-17 11:57:36 +00:00

max.mehl commented

2019-03-20 17:16:32 +00:00

check-translation-status.sh at least extracts the last commit date from the git history. Getting the author shouldn't be a huge problem either

[check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) at least extracts the last commit date from the git history. Getting the author shouldn't be a huge problem either

max.mehl commented

2019-05-22 10:03:56 +00:00

Related to #64 where we discuss about the impact of getting author/timestamp info via Git

reinhard changed title from ~~"Last changed" in footer display build info instead of commit info~~ to "Last changed" in footer displays build info instead of commit info

2019-05-25 14:57:15 +00:00

reinhard referenced this issue

2020-04-21 19:02:27 +00:00

Translation warning box sometimes wrong #64

reinhard commented

2020-04-21 19:18:36 +00:00

Please note that there is much discussion about possible approaches to this in #64 and some experiments around these approaches in #952 and #974. Special thanks to @ulf for these pull requests!

However, now as we decided for a way to detect outdated translations completely independently from git commit times, I get more and more convinced that having the date of the last commit displayed in the footer (or even just in a HTML comment) is not worth the effort we would have to spend on it.

I actually even think that displaying date and author of the last commit is not useful at all, because the last commit could be a purely technical one (like some change in the tag structure) and displaying that date would make a wrong impression about the last actual update of the content.

So in the end I propose to:

delete all processing of the <timestamp> element in the build script and the XSL templates, thus removing that bit of information from the footer
delete the <timestamp> element from all files
close this issue as well as the two pull requests #952 and #974

Please note that there is much discussion about possible approaches to this in #64 and some experiments around these approaches in #952 and #974. Special thanks to @ulf for these pull requests! However, now as we decided for a way to detect outdated translations completely independently from git commit times, I get more and more convinced that having the date of the last commit displayed in the footer (or even just in a HTML comment) is not worth the effort we would have to spend on it. I actually even think that displaying date and author of the last commit is not useful at all, because the last commit could be a purely technical one (like some change in the tag structure) and displaying that date would make a wrong impression about the last actual update of the content. So in the end I propose to: * delete all processing of the `<timestamp>` element in the build script and the XSL templates, thus removing that bit of information from the footer * delete the `<timestamp>` element from all files * close this issue as well as the two pull requests #952 and #974

max.mehl commented

2020-04-22 15:55:13 +00:00

Would be fine with me. The argument about the confusion git commit vs actual content change convinces me that this timestamp may be problematic.

reinhard closed this issue

2020-04-27 12:18:18 +00:00

reinhard reopened this issue

2020-04-27 12:18:36 +00:00

reinhard referenced this issue

2020-04-27 12:19:00 +00:00

WIP: Use git commit times instead of file timestamps when possible #952

reinhard referenced this issue

2020-04-27 12:19:24 +00:00