#837 "Last changed" in footer displays build info instead of commit info

Closed
opened 1 year ago by reinhard · 4 comments
reinhard commented 1 year ago

The “Last changed:” in the footer of each page displays the date of the last build run and the fixed text “automatic” instaed of the date of the last change to the source file and the author of that change.

The "Last changed:" in the footer of each page displays the date of the last build run and the fixed text "automatic" instaed of the date of the last change to the source file and the author of that change.
reinhard added the
build
label 1 year ago
reinhard added the
system-hackers
label 1 year ago
reinhard added the
xsl
label 1 year ago
max.mehl commented 1 year ago
Owner

check-translation-status.sh at least extracts the last commit date from the git history. Getting the author shouldn’t be a huge problem either

[check-translation-status.sh](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/check-translation-status.sh) at least extracts the last commit date from the git history. Getting the author shouldn't be a huge problem either
max.mehl commented 1 year ago
Owner

Related to #64 where we discuss about the impact of getting author/timestamp info via Git

Related to #64 where we discuss about the impact of getting author/timestamp info via Git
reinhard changed title from "Last changed" in footer display build info instead of commit info to "Last changed" in footer displays build info instead of commit info 1 year ago
reinhard commented 3 months ago
Poster

Please note that there is much discussion about possible approaches to this in #64 and some experiments around these approaches in #952 and #974. Special thanks to @ulf for these pull requests!

However, now as we decided for a way to detect outdated translations completely independently from git commit times, I get more and more convinced that having the date of the last commit displayed in the footer (or even just in a HTML comment) is not worth the effort we would have to spend on it.

I actually even think that displaying date and author of the last commit is not useful at all, because the last commit could be a purely technical one (like some change in the tag structure) and displaying that date would make a wrong impression about the last actual update of the content.

So in the end I propose to:

  • delete all processing of the <timestamp> element in the build script and the XSL templates, thus removing that bit of information from the footer
  • delete the <timestamp> element from all files
  • close this issue as well as the two pull requests #952 and #974
Please note that there is much discussion about possible approaches to this in #64 and some experiments around these approaches in #952 and #974. Special thanks to @ulf for these pull requests! However, now as we decided for a way to detect outdated translations completely independently from git commit times, I get more and more convinced that having the date of the last commit displayed in the footer (or even just in a HTML comment) is not worth the effort we would have to spend on it. I actually even think that displaying date and author of the last commit is not useful at all, because the last commit could be a purely technical one (like some change in the tag structure) and displaying that date would make a wrong impression about the last actual update of the content. So in the end I propose to: * delete all processing of the `<timestamp>` element in the build script and the XSL templates, thus removing that bit of information from the footer * delete the `<timestamp>` element from all files * close this issue as well as the two pull requests #952 and #974
max.mehl commented 3 months ago
Owner

Would be fine with me. The argument about the confusion git commit vs actual content change convinces me that this timestamp may be problematic.

Would be fine with me. The argument about the confusion git commit vs actual content change convinces me that this timestamp may be problematic.
reinhard closed this issue 3 months ago
reinhard reopened this issue 3 months ago
reinhard self-assigned this 3 months ago
reinhard closed this issue 3 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.