FSFE/fsfe-website
25
31
Fork 91
Code Issues 64 Pull Requests 4 Wiki Activity

SVG Images and the aspect ratio check #3124

New Issue
Open
opened 2023-01-09 10:25:48 +00:00 by tobiasd · 0 comments
tobiasd commented 2023-01-09 10:25:48 +00:00
Owner
Copy Link

The image aspect ratio check (in the pre-commit hook) seems to have a problem with SVG images. It cannot determine the width and height of the image so that the ratio calculation fails with an devision by zero

The image aspect ratio check (in the [pre-commit hook](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/githooks/pre-commit#L309)) seems to have a problem with SVG images. It cannot determine the width and height of the image so that the [ratio calculation](https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/tools/githooks/pre-commit#L342) fails with an devision by zero
tobiasd added the
bug
 label 2023-01-09 10:25:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label
bug
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bonnie cryptie dario delliott dmaphy doczkal eal egnun eventregbot fi floriansnow gabriel.ku guido hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard repentinus schiessle sofiaritz tobiasd vincent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#3124
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?