Invalid HTML #282
Labels
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: FSFE/fsfe-website#282
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
See for example this report.
I'll take this one. @reinhard could you assign the ticket to me?
The description is in my opinion a bit too broad. I'll do the things I find by looking at some pages. Maybe it makes more sense to specify the affected pages.
I can't assign the ticket to you, you don't appear in the list of potential assigniees. I have no idea why :-/
Now it worked. I had to add you to a team with write access to this repo, no idea why...
It seems we are better now. The only error is the newsteaser attribute in
<p>
: reportThe missing "alt" text about the image can be fixed easy.
On the other hand, the "newsteaser" attribute to the "p" element is not accepted as valid HTML. The "newsteaser" element is being used on a lot of pages. A list of accepted attributes of "p": https://html.spec.whatwg.org/multipage/dom.html#global-attributes. The decision to use a "semantic" tag into news pages has its advantages but has been implemented in a non-valid way.
It looks like the suitable way to semantically define the summary of a news article and enable it for syndication is the element "article". In the current use case I would suggest to wrap "h1" and the newsteaser into an "article".
and do that every time. Is Web Team OK with this?
Used sources:
https://internetingishard.com/html-and-css/semantic-html/ -
https://bitsofco.de/sectioning-content-in-html5/
I don't think that the use of the
<article>
tag for this would be semantically correct.Why not just change
<p newsteaser="yes">
into<p class="newsteaser">
?Please note that it must also be changed in fsfe.less and in news/xhtml2xml.xsl.
Additional source:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article
I still think that
<article>
is not the right tag for this. While it is true that the heading together with the newsteaser paragraph is used for syndication on other resources (like the frontpage or the news archive), on the news article page itself the semantic meaning of the<article>
applies to the whole news article.See PR #1097 for a solution of the
newsteaser
attribute testLooks like the errors caused by the general page structure are now fixed, let's now also fix the warnings.