FSFE
/
fsfe-website
29
30
Fork 85
Code Issues 61 Pull Requests 14 Wiki Activity

Build chokes on & in tag name #2331

New Issue
Open
opened 2021-11-29 09:47:07 +00:00 by max.mehl · 1 comment
max.mehl commented 2021-11-29 09:47:07 +00:00
Owner
Copy Link

I tried to have the tag name contain an & in this commit.

In normal text, that works. In our build system, that leads to an error – not on the news item itself but when building the tag page as it seems.

Here an extract from Phase 2 of the build:

[09:20:24] * Building tags/tagged-childrensbook.zh.html
[09:20:24] * Building tags/tags.ar.html
[09:20:24] * Building tags/tags.bg.html
[09:20:24] * Building tags/tags.bs.html
[09:20:24] -:329: parser error : xmlParseEntityRef: no name
[09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za
[09:20:24] ^
[09:20:24] unable to parse -
[09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:44: /srv/www/fsfe.org_stage/tags/tags.ar.html] Error 6
[09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.ar.html'
[09:20:24] make: *** Waiting for unfinished jobs....
[09:20:24] -:336: parser error : xmlParseEntityRef: no name
[09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za
[09:20:24] ^
[09:20:24] unable to parse -
[09:20:24] -:369: parser error : xmlParseEntityRef: no name
[09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za
[09:20:24] ^
[09:20:24] unable to parse -
[09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:47: /srv/www/fsfe.org_stage/tags/tags.bg.html] Error 6
[09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bg.html'
[09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:50: /srv/www/fsfe.org_stage/tags/tags.bs.html] Error 6
[09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bs.html'
[09:20:24] 1638177624

Interestingly, the actual tag's page builds fine: [09:20:23] * Building tags/tagged-adaandzangemann.en.html

It's not high priority, but an unexpected behaviour.

I tried to have the tag name contain an `&amp;` in [this commit](https://git.fsfe.org/FSFE/fsfe-website/commit/4243c4fdb027127867ea8c01790778c244856404). In normal text, that works. In our build system, that leads to an error – not on the news item itself but when building the tag page as it seems. Here an extract from Phase 2 of the build: ``` [09:20:24] * Building tags/tagged-childrensbook.zh.html [09:20:24] * Building tags/tags.ar.html [09:20:24] * Building tags/tags.bg.html [09:20:24] * Building tags/tags.bs.html [09:20:24] -:329: parser error : xmlParseEntityRef: no name [09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za [09:20:24] ^ [09:20:24] unable to parse - [09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:44: /srv/www/fsfe.org_stage/tags/tags.ar.html] Error 6 [09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.ar.html' [09:20:24] make: *** Waiting for unfinished jobs.... [09:20:24] -:336: parser error : xmlParseEntityRef: no name [09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za [09:20:24] ^ [09:20:24] unable to parse - [09:20:24] -:369: parser error : xmlParseEntityRef: no name [09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za [09:20:24] ^ [09:20:24] unable to parse - [09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:47: /srv/www/fsfe.org_stage/tags/tags.bg.html] Error 6 [09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bg.html' [09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:50: /srv/www/fsfe.org_stage/tags/tags.bs.html] Error 6 [09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bs.html' [09:20:24] 1638177624 ``` Interestingly, the actual tag's page builds fine: `[09:20:23] * Building tags/tagged-adaandzangemann.en.html` It's not high priority, but an unexpected behaviour.
max.mehl added the
bug
tagging
xsl
build
 labels 2021-11-29 09:47:07 +00:00
tobiasd commented 2023-03-29 12:54:02 +00:00
Owner
Copy Link

In xml files the build system chokes as well on an & in the text.

In xml files the build system chokes as well on an `&` in the text.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
test
fixing
news-20240229
20240223-RF
ilovefs24-updates
SFP024-ilovefs-episode
ilovefs_typo
ilovefs24-patch-2
ilovefs24-events-patch-1
ilovefs24-events-patch
kauffmann-quote
news-20240122
news-20231207-Ada
about-page-small-changes
20231122-ada
news-20231120-YH4F
proofreading_legal_issues
feature/license-annotations
compare-xml-structure
followup-default-mail
feature/peertube-for-upcycle-android
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#2331
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?