FSFE/fsfe-website
27
32
Fork 93
Code Issues 63 Pull Requests 19 Wiki Activity

Build chokes on & in tag name #2331

New Issue
Closed
opened 2021-11-29 09:47:07 +00:00 by max.mehl · 4 comments
max.mehl commented 2021-11-29 09:47:07 +00:00
Owner
Copy Link

I tried to have the tag name contain an & in this commit.

In normal text, that works. In our build system, that leads to an error – not on the news item itself but when building the tag page as it seems.

Here an extract from Phase 2 of the build:

[09:20:24] * Building tags/tagged-childrensbook.zh.html
[09:20:24] * Building tags/tags.ar.html
[09:20:24] * Building tags/tags.bg.html
[09:20:24] * Building tags/tags.bs.html
[09:20:24] -:329: parser error : xmlParseEntityRef: no name
[09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za
[09:20:24] ^
[09:20:24] unable to parse -
[09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:44: /srv/www/fsfe.org_stage/tags/tags.ar.html] Error 6
[09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.ar.html'
[09:20:24] make: *** Waiting for unfinished jobs....
[09:20:24] -:336: parser error : xmlParseEntityRef: no name
[09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za
[09:20:24] ^
[09:20:24] unable to parse -
[09:20:24] -:369: parser error : xmlParseEntityRef: no name
[09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za
[09:20:24] ^
[09:20:24] unable to parse -
[09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:47: /srv/www/fsfe.org_stage/tags/tags.bg.html] Error 6
[09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bg.html'
[09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:50: /srv/www/fsfe.org_stage/tags/tags.bs.html] Error 6
[09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bs.html'
[09:20:24] 1638177624

Interestingly, the actual tag's page builds fine: [09:20:23] * Building tags/tagged-adaandzangemann.en.html

It's not high priority, but an unexpected behaviour.

I tried to have the tag name contain an `&amp;` in [this commit](https://git.fsfe.org/FSFE/fsfe-website/commit/4243c4fdb027127867ea8c01790778c244856404). In normal text, that works. In our build system, that leads to an error – not on the news item itself but when building the tag page as it seems. Here an extract from Phase 2 of the build: ``` [09:20:24] * Building tags/tagged-childrensbook.zh.html [09:20:24] * Building tags/tags.ar.html [09:20:24] * Building tags/tags.bg.html [09:20:24] * Building tags/tags.bs.html [09:20:24] -:329: parser error : xmlParseEntityRef: no name [09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za [09:20:24] ^ [09:20:24] unable to parse - [09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:44: /srv/www/fsfe.org_stage/tags/tags.ar.html] Error 6 [09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.ar.html' [09:20:24] make: *** Waiting for unfinished jobs.... [09:20:24] -:336: parser error : xmlParseEntityRef: no name [09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za [09:20:24] ^ [09:20:24] unable to parse - [09:20:24] -:369: parser error : xmlParseEntityRef: no name [09:20:24] <tag section="news" key="adaandzangemann" count="1" filename="tags">Ada & Za [09:20:24] ^ [09:20:24] unable to parse - [09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:47: /srv/www/fsfe.org_stage/tags/tags.bg.html] Error 6 [09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bg.html' [09:20:24] make: *** [/srv/www/status.fsfe.org/fsfe.org/Makefile:50: /srv/www/fsfe.org_stage/tags/tags.bs.html] Error 6 [09:20:24] make: *** Deleting file '/srv/www/fsfe.org_stage/tags/tags.bs.html' [09:20:24] 1638177624 ``` Interestingly, the actual tag's page builds fine: `[09:20:23] * Building tags/tagged-adaandzangemann.en.html` It's not high priority, but an unexpected behaviour.
max.mehl added the bugtaggingxslbuild labels 2021-11-29 09:47:07 +00:00
tobiasd commented 2023-03-29 12:54:02 +00:00
Owner
Copy Link

In xml files the build system chokes as well on an & in the text.

In xml files the build system chokes as well on an `&` in the text.
delliott commented 2025-09-02 15:42:39 +00:00
Member
Copy Link

So, with the new build system a tag name with an ampersand in it is fine, ie

<tag key="test">test&amp;</tag>

builds just fine, and renders properly on the actual list of tags for the page.

But in the tag overview the &amp is not parsed into an ampersand due to us escaping the xml text:

fsfe-website/fsfe.org/tags/subdir.py Line 118 in 0f8805e037
escape(tag.text.strip()) if tag.text and tag.text.strip() else None

I think this is because of some other issues we had, but I do not think that matters too much?

Using & in the key of a tag does not work, IE

<tag key="test&amp;">test&amp;</tag>

Results in a build error.

We still do not support an & in xml text with the new build process, but it works in xhtml it seems?

Perhaps we can close this issue?

So, with the new build system a tag name with an ampersand in it is fine, ie ```xml <tag key="test">test&amp;</tag> ``` builds just fine, and renders properly on the actual list of tags for the page. But in the tag overview the &amp is not parsed into an ampersand due to us escaping the xml text: https://git.fsfe.org/FSFE/fsfe-website/src/commit/0f8805e037cd435d189a1ce8b506c631feb37389/fsfe.org/tags/subdir.py#L118 I think this is because of some other issues we had, but I do not think that matters too much? Using &amp; in the key of a tag does not work, IE ```xml <tag key="test&amp;">test&amp;</tag> ``` Results in a build error. We still do not support an & in xml text with the new build process, but it works in xhtml it seems? Perhaps we can close this issue?
delliott commented 2025-09-03 09:37:21 +00:00
Member
Copy Link

It seems the escaping tag names was not in fact necessary, and I have pr to remove it here: #5279

This means that after that pr is merged using an &amp; in a tag text works perfectly, which I think satisfies this issue. @tobiasd

It seems the escaping tag names was not in fact necessary, and I have pr to remove it here: https://git.fsfe.org/FSFE/fsfe-website/pulls/5279 This means that after that pr is merged using an `&amp;` in a tag text works perfectly, which I think satisfies this issue. @tobiasd
tobiasd commented 2025-09-06 06:08:20 +00:00
Owner
Copy Link

thanks!

thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label bug build tagging xsl
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bcludts bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi fkobi floriansnow gabriel.ku guido hl hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#2331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?