Incoherent upper section in Activities pages #2084

New Issue

criadoperez · 2021-08-11T12:00:54Z

criadoperez commented

2021-08-11 12:00:54 +00:00

The following 4 pages are meant to have a common top section:

The actual file activities.en.html states this on line 13:

However there is an extra phrase that only appears in the legal.en.html page and not in the other 3 files. This missing phrase is:

We also provide basic education resources on Free Software legal and licensing issues.*

I have copied that phrase to the other 3 files in the PR #2082
I have not changed this version number of any of the files. Please do if you consider it necessary.

The following 4 pages are meant to have a common top section: * https://fsfe.org/activities/activities.en.html * https://fsfe.org/activities/awareness.en.html * https://fsfe.org/activities/policy.en.html * https://fsfe.org/activities/legal.en.html The actual file activities.en.html states this on line 13:  However there is an extra phrase that only appears in the legal.en.html page and not in the other 3 files. This missing phrase is: * We also provide basic education resources on Free Software legal and licensing issues.* I have copied that phrase to the other 3 files in the PR [#2082](https://git.fsfe.org/FSFE/fsfe-website/pulls/2082) I have not changed this version number of any of the files. Please do if you consider it necessary.

max.mehl commented

2021-08-12 12:57:37 +00:00

Thank you for spotting this!

I lost oversight in this very big Pull Request. It would have been great to split it into logical units, e.g. basic fixes like this that also affect other translations, and pure translations to ES.

Since your spotted mistake here has to be transposed in other languages as well, the version number has to be bumped, see https://wiki.fsfe.org/TechDocs/Mainpage/Translations/Outdated

Thank you for spotting this! I lost oversight in this very big Pull Request. It would have been great to split it into logical units, e.g. basic fixes like this that also affect other translations, and pure translations to ES. Since your spotted mistake here has to be transposed in other languages as well, the version number has to be bumped, see https://wiki.fsfe.org/TechDocs/Mainpage/Translations/Outdated

max.mehl added the

bug

label 2021-08-12 13:02:17 +00:00

criadoperez commented

2021-08-12 13:07:24 +00:00

Practically the entire PR is ES translation, with the exceptions being marked out.
I spotted a couple more things (translations and not), but don't want to add more to the PR.
I'm waiting for it to be merged, to re-view the changes in the browser and create a new one.
For next time if you prefer I can create two branches (one for translations) and one for the rest and send to independent PR requests. You prefer this approach?

Practically the entire PR is ES translation, with the exceptions being marked out. I spotted a couple more things (translations and not), but don't want to add more to the PR. I'm waiting for it to be merged, to re-view the changes in the browser and create a new one. For next time if you prefer I can create two branches (one for translations) and one for the rest and send to independent PR requests. You prefer this approach?

👍 1

criadoperez commented

2021-08-12 13:18:24 +00:00

Ok. Bumped version number to the en and es files. Its in PR #2082

👍 1

max.mehl referenced a pull request that will close this issue

2021-08-12 13:23:58 +00:00

Fixed broken links and multiple [ES] translations #2082

bonnie referenced this issue from a commit

2021-08-13 14:13:49 +00:00

Fixed broken links and multiple [ES] translations (#2082)

bonnie closed this issue