Validate the contents of fingerprint and keyhref fields in about/people/people.en.xml #1653

New Issue

repentinus · 2020-10-01T01:07:35Z

repentinus commented

2020-10-01 01:07:35 +00:00

fingerprint

automatically remove whitespace and convert to uppercase
check the content is 40 hex digits before including it in the HTML

keyhref

HTTPS URL
query parameters do not contain a short or long key ID
query parameters do not contain an e-mail address

# fingerprint * automatically remove whitespace and convert to uppercase * check the content is 40 hex digits before including it in the HTML # keyhref * HTTPS URL * query parameters do not contain a short or long key ID * query parameters do not contain an e-mail address

repentinus added the xsl easy priority/low labels 2020-10-01 01:07:35 +00:00

max.mehl commented

2020-10-13 13:32:17 +00:00

Sorry, I'm not sure I understand what this issue is about. Do you expect the XSL matching these fields against some regex?

And if so, what should happen if the match was unsuccessful?

Sorry, I'm not sure I understand what this issue is about. Do you expect the XSL matching these fields against some regex? And if so, what should happen if the match was unsuccessful?

repentinus commented

2020-10-13 13:50:20 +00:00

Yes. The simplest option is to simply omit the fingerprint or the link to the key (as appropriate) from the HTML output if the contents do not match the requirements.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1653