Tags page links to external sites rather than the event containing them #1420

New Issue

jzarl · 2020-05-29T21:50:18Z

jzarl commented

2020-05-29 21:50:18 +00:00

As written in #935 (comment), events with external links are reduced to the external link when shown on the tags page.

IMO it is quite unexpected that clicking a link on the tags page can take me to anything but the page containing the tag, much less to an external website.

Steps to reproduce:

Go to https://fsfe.org/tags/tagged-helsinki-openoffice.de.html
Click on the link "Talk: An endangered species: computer as a universal machine"

Expected behaviour:
The link points to the event entry below https://fsfe.org/events/.

Actual behaviour:
The link points to the external website referenced in the event page.

With the current site layout, there seems to be no way to create a link satisfying the "Expected behaviour". As a minimum, the article nodes on the events page would need an anchor so that they can be linked to. Another option would be to create a page for every event.

As written in https://git.fsfe.org/FSFE/fsfe-website/issues/935#issuecomment-8800, events with external links are reduced to the external link when shown on the tags page. IMO it is quite unexpected that clicking a link on the tags page can take me to anything but the page containing the tag, much less to an external website. Steps to reproduce: 1. Go to https://fsfe.org/tags/tagged-helsinki-openoffice.de.html 2. Click on the link "Talk: An endangered species: computer as a universal machine" Expected behaviour: The link points to the event entry below https://fsfe.org/events/. Actual behaviour: The link points to the external website referenced in the event page. With the current site layout, there seems to be no way to create a link satisfying the "Expected behaviour". As a minimum, the `article` nodes on the events page would need an anchor so that they can be linked to. Another option would be to create a page for every event.

reinhard commented

2020-05-30 06:03:22 +00:00

As a minimum, the article nodes on the events page would need an anchor so that they can be linked to.

Actually, the article nodes do have an id. See for example https://fsfe.org/events/index.html#event-20200201-01

If we decide to link to that page, we have to take care that, for older events, the link should point to the yearly event archive page instead.

Another option would be to create a page for every event.

Personally I think that would be overkill.

Another option that comes to my mind is to switch the news and events listing on the tag pages to the verbose format (as in https://fsfe.org/events/index.html minus the tags).

> As a minimum, the `article` nodes on the events page would need an anchor so that they can be linked to. Actually, the `article` nodes *do* have an id. See for example https://fsfe.org/events/index.html#event-20200201-01 If we decide to link to that page, we have to take care that, for older events, the link should point to the yearly event archive page instead. > Another option would be to create a page for every event. Personally I think that would be overkill. Another option that comes to my mind is to switch the news and events listing on the tag pages to the verbose format (as in https://fsfe.org/events/index.html minus the tags).

reinhard commented

2020-05-30 08:02:32 +00:00

FWIW, back in the good old days, we differed between <link> for links to fsfe-owned pages and <page> for links to external web pages in event entries. This has been removed (I have no idea why), maybe we should consider to reintroduce this distinction.

FWIW, back in the good old days, we differed between `<link>` for links to fsfe-owned pages and `<page>` for links to external web pages in event entries. This has been removed (I have no idea why), maybe we should consider to reintroduce this distinction.

Sign in to join this conversation.

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1420