FSFE/fsfe-website
24
30
Fork 88
Code Issues 62 Pull Requests 12 Wiki Activity

Proposal: put share-buttons after sidebar #1381

New Issue
Open
opened 2020-05-13 16:10:50 +00:00 by reinhard · 5 comments
reinhard commented 2020-05-13 16:10:50 +00:00
Member
Copy Link

I propose to place the share-buttons outside of #content and after #sidebar (but still inside #main). Results would be:

  • In mobile view, share-buttons are shown below the sidebar content instead of above it.
  • In desktop view, share-buttons would span the whole width even if there is a sidebar.
  • In desktop view, if the sidebar is longer than the actual content (probably a rare case), the spacing between content and share-buttons grows.

Please let me know what you think, and whether you'd think we should do the same for the discussion link and the tag list below a news item.

I propose to place the share-buttons outside of #content and after #sidebar (but still inside #main). Results would be: * In mobile view, share-buttons are shown below the sidebar content instead of above it. * In desktop view, share-buttons would span the whole width even if there is a sidebar. * In desktop view, if the sidebar is longer than the actual content (probably a rare case), the spacing between content and share-buttons grows. Please let me know what you think, and whether you'd think we should do the same for the discussion link and the tag list below a news item.
max.mehl commented 2020-05-15 11:21:22 +00:00
Owner
Copy Link

I agree for the share-buttons, but not sure for tags and discussion link. But since the latter two are shorter than the whole #content anyway, it wouldn't make an optical difference, so I guess I wouldn't care too much ;)

I agree for the share-buttons, but not sure for tags and discussion link. But since the latter two are shorter than the whole #content anyway, it wouldn't make an optical difference, so I guess I wouldn't care too much ;)
reinhard commented 2020-05-15 11:35:01 +00:00
Author
Member
Copy Link

@max.mehl in the desktop view there would not be any visible difference, but in the mobile view, where the "sidebar" is below the #content instead of beside it, it's about whether these elements (tags and discussion link) are above or below the sidebar section.

@max.mehl in the desktop view there would not be any visible difference, but in the mobile view, where the "sidebar" is below the #content instead of beside it, it's about whether these elements (tags and discussion link) are above or below the sidebar section.
max.mehl commented 2020-05-15 11:48:46 +00:00
Owner
Copy Link

Ah. The slight problem I have with the mobile view is that the sidebar also contains some generic blurb which most people won't read, but just close the window. This way, the whole share thingy is invisible for them.

However, syntactically, it makes sense to have this meta information and the share buttons be a separate part though, so I'm split here

Ah. The slight problem I have with the mobile view is that the sidebar also contains some generic blurb which most people won't read, but just close the window. This way, the whole share thingy is invisible for them. However, syntactically, it makes sense to have this meta information and the share buttons be a separate part though, so I'm split here
reinhard commented 2020-05-16 11:19:25 +00:00
Author
Member
Copy Link

Just an idea: How about, in the mobile view, making the sidebar a foldable section which is normally hidden? And if we follow that idea, what could be the title of this section?

Just an idea: How about, in the mobile view, making the sidebar a foldable section which is normally hidden? And if we follow that idea, what could be the title of this section?
max.mehl commented 2020-05-19 14:38:35 +00:00
Owner
Copy Link

That could work, something like "Further information" or so? However, some sidebars already have this title...

That could work, something like "Further information" or so? However, some sidebars already have this title...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
build

   
cgi Scripting

   
design

   
disruptive

Requires careful coordination and documentation changes

  
documentation

   
duplicate

   
easy

   
feature-request

   
help wanted

   
javascript

   
priority/low

   
question

   
system-hackers

   
tagging

   
text

   
translations

   
wait/bugfix

   
wait/inprogress

   
wait/misc

   
wait/proofread

   
wontfix

   
xsl
No Label
bug
build
cgi Scripting
design
disruptive
documentation
duplicate
easy
feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1381
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?