FSFE/fsfe-website
27
33
Fork 93
Code Issues 64 Pull Requests 18 Wiki Activity

Comment between <xml> and <html> lines in source file breaks build #1239

New Issue
Closed
opened 2020-03-02 08:01:51 +00:00 by reinhard · 1 comment
reinhard commented 2020-03-02 08:01:51 +00:00
Member
Copy Link

A comment like the one in the second line in commit 09a40714eb breaks the build.

A comment like the one in the second line in commit https://git.fsfe.org/FSFE/fsfe-website/commit/09a40714eb554fd6e88476618fa1c68a60cf091e breaks the build.
max.mehl added the build label 2020-03-02 13:33:57 +00:00
delliott commented 2025-12-10 20:09:36 +00:00
Member
Copy Link

Given that we have such a comment in master, see https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/fsfe.org/boilerplate.en.xhtml#L1-L6 (permalink:

fsfe-website/fsfe.org/boilerplate.en.xhtml Lines 1 to 6 in a3439f4886
<?xml version="1.0" encoding="utf-8"?>
<!-- Do not translate this file. -->
<!--Please update the date to the date you would like to publish the news item and delete the comment around the newsdate. The date you want to publish the news item does not need to be the date you create or merge the Pull Request-->
<!-- html newsdate="YYYY-MM-DD" -->
<!---->
<html>
), I think this issue can be closed.

It must have been fixed at some point long ago.

Given that we have such a comment in master, see https://git.fsfe.org/FSFE/fsfe-website/src/branch/master/fsfe.org/boilerplate.en.xhtml#L1-L6 (permalink: https://git.fsfe.org/FSFE/fsfe-website/src/commit/a3439f4886472212369f36ed0d5fe112a77f2238/fsfe.org/boilerplate.en.xhtml#L1-L6), I think this issue can be closed. It must have been fixed at some point long ago.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
build
cgi Scripting
design
disruptive
Requires careful coordination and documentation changes
 documentation
duplicate
easy
enhancement
Improving what is already there
 feature-request
help wanted
javascript
priority/low
question
system-hackers
tagging
text
translations
wait/bugfix
wait/inprogress
wait/misc
wait/proofread
wontfix
xsl
No Label build
Milestone
No items
No Milestone
Assignees
Clear assignees
albert alex.busch alex.sander anaghz ao bcludts bonnie cryptie dario delliott dfajfer dmaphy doczkal eal egnun eventregbot fi floriansnow gabriel.ku guido hugo ineiev jn jzarl linus lucabon lucas.lasota max.mehl mk monochromec mweimann nico.rikken patrick reinhard renovate-bot repentinus schiessle sofiaritz tobiasd vincent
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FSFE/fsfe-website#1239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?